server/favorites: favoriting sets score to 1

3 files changed, 10 insertions, 5 deletions

diff --git a/server/szurubooru/tests/api/test_comment_rating.py b/server/szurubooru/tests/api/test_comment_rating.py
index 2632dc0..c0a00cc 100644
--- a/server/szurubooru/tests/api/test_comment_rating.py
+++ b/server/szurubooru/tests/api/test_comment_rating.py
@@ -110,8 +110,8 @@ def test_ratings_from_multiple_users(test_ctx, fake_datetime):
 @pytest.mark.parametrize('input,expected_exception', [
     ({'score': None}, errors.ValidationError),
     ({'score': ''}, errors.ValidationError),
-    ({'score': -2}, scores.InvalidScoreError),
-    ({'score': 2}, scores.InvalidScoreError),
+    ({'score': -2}, scores.InvalidScoreValueError),
+    ({'score': 2}, scores.InvalidScoreValueError),
     ({'score': [1]}, errors.ValidationError),
 ])
 def test_trying_to_pass_invalid_input(test_ctx, input, expected_exception):
diff --git a/server/szurubooru/tests/api/test_post_favoriting.py b/server/szurubooru/tests/api/test_post_favoriting.py
index f4e0aa0..00a1035 100644
--- a/server/szurubooru/tests/api/test_post_favoriting.py
+++ b/server/szurubooru/tests/api/test_post_favoriting.py
@@ -23,10 +23,11 @@ def test_ctx(
     ret.api = api.PostFavoriteApi()
     return ret
 
-def test_simple_rating(test_ctx, fake_datetime):
+def test_adding_to_favorites(test_ctx, fake_datetime):
     post = test_ctx.post_factory()
     db.session.add(post)
     db.session.commit()
+    assert post.score == 0
     with fake_datetime('1997-12-01'):
         result = test_ctx.api.post(
             test_ctx.context_factory(user=test_ctx.user_factory()),
@@ -37,21 +38,25 @@ def test_simple_rating(test_ctx, fake_datetime):
     assert db.session.query(db.PostFavorite).count() == 1
     assert post is not None
     assert post.favorite_count == 1
+    assert post.score == 1
 
 def test_removing_from_favorites(test_ctx, fake_datetime):
     user = test_ctx.user_factory()
     post = test_ctx.post_factory()
     db.session.add(post)
     db.session.commit()
+    assert post.score == 0
     with fake_datetime('1997-12-01'):
         result = test_ctx.api.post(
             test_ctx.context_factory(user=user),
             post.post_id)
+    assert post.score == 1
     with fake_datetime('1997-12-02'):
         result = test_ctx.api.delete(
             test_ctx.context_factory(user=user),
             post.post_id)
     post = db.session.query(db.Post).one()
+    assert post.score == 1
     assert db.session.query(db.PostFavorite).count() == 0
     assert post.favorite_count == 0
 
diff --git a/server/szurubooru/tests/api/test_post_rating.py b/server/szurubooru/tests/api/test_post_rating.py
index b8c9cb2..a48830e 100644
--- a/server/szurubooru/tests/api/test_post_rating.py
+++ b/server/szurubooru/tests/api/test_post_rating.py
@@ -106,8 +106,8 @@ def test_ratings_from_multiple_users(test_ctx, fake_datetime):
 @pytest.mark.parametrize('input,expected_exception', [
     ({'score': None}, errors.ValidationError),
     ({'score': ''}, errors.ValidationError),
-    ({'score': -2}, scores.InvalidScoreError),
-    ({'score': 2}, scores.InvalidScoreError),
+    ({'score': -2}, scores.InvalidScoreValueError),
+    ({'score': 2}, scores.InvalidScoreValueError),
     ({'score': [1]}, errors.ValidationError),
 ])
 def test_trying_to_pass_invalid_input(test_ctx, input, expected_exception):