server/posts: defer flush; save content lazily

Rather than flushing the post right away only to find out that there
were validation errors, try to postpone flushing for as long as
possible.

The previous behavior has led to too eager spending of post IDs - each
flush calls nextval(post_id_seq), and postgres sequences are not
affected by transaction rollbacks, so each erroneous post creation
discarded a post ID, which has led to gaps in post IDs.

1 files changed, 3 insertions, 3 deletions

diff --git a/server/szurubooru/api/post_api.py b/server/szurubooru/api/post_api.py
index 34e007c..e4d4975 100644
--- a/server/szurubooru/api/post_api.py
+++ b/server/szurubooru/api/post_api.py
@@ -44,9 +44,6 @@ def create_post(ctx, _params=None):
         content, tag_names, None if anonymous else ctx.user)
     if len(new_tags):
         auth.verify_privilege(ctx.user, 'tags:create')
-        db.session.flush()
-        for tag in new_tags:
-            snapshots.create(tag, None if anonymous else ctx.user)
     posts.update_post_safety(post, safety)
     posts.update_post_source(post, source)
     posts.update_post_relations(post, relations)
@@ -55,7 +52,10 @@ def create_post(ctx, _params=None):
     if ctx.has_file('thumbnail'):
         posts.update_post_thumbnail(post, ctx.get_file('thumbnail'))
     ctx.session.add(post)
+    ctx.session.flush()
     snapshots.create(post, None if anonymous else ctx.user)
+    for tag in new_tags:
+        snapshots.create(tag, None if anonymous else ctx.user)
     ctx.session.commit()
     tags.export_to_json()
     return _serialize_post(ctx, post)