From 59e80445882f8b0379e54916f89510c0deda6698 Mon Sep 17 00:00:00 2001 From: Ludovic Courtès Date: Wed, 13 Mar 2019 16:44:02 +0100 Subject: Remove traces of "GuixSD". * gnu/bootloader/extlinux.scm (extlinux-configuration-file): Remove mentions of "GuixSD". * gnu/bootloader/grub.scm (install-grub-efi): Likewise. * gnu/build/vm.scm (make-iso9660-image): Change default #:volume-id to "Guix_image". (initialize-hard-disk): Search for the "Guix_image" label. * gnu/ci.scm (system-test-jobs, tarball-jobs): Remove "GuixSD". * gnu/installer/newt/welcome.scm (run-welcome-page): Likewise. * gnu/packages/audio.scm (supercollider)[description]: Likewise. * gnu/packages/curl.scm (curl): Likewise. * gnu/packages/emacs.scm (emacs): Likewise. * gnu/packages/gnome.scm (network-manager): Likewise. * gnu/packages/julia.scm (julia): Likewise. * gnu/packages/linux.scm (alsa-plugins): Likewise. (powertop, wireless-regdb): Likewise. * gnu/packages/package-management.scm (guix): Likewise. * gnu/packages/polkit.scm (polkit): Likewise. * gnu/packages/tex.scm (texlive-bin): Likewise. * gnu/services/base.scm (file-systems->fstab): Likewise. * gnu/services/cups.scm (%cups-activation): Likewise. * gnu/services/mail.scm (%dovecot-activation): Likewise. * gnu/services/messaging.scm (prosody-configuration)[log]: Likewise. * gnu/system/examples/vm-image.tmpl (vm-image-motd): Likewise. * gnu/system/install.scm (installation-os)[file-systems]: Change root file system label to "Guix_image". * gnu/system/mapped-devices.scm (check-device-initrd-modules): Remove "GuixSD". * gnu/system/vm.scm (system-docker-image): Likewise. (system-disk-image)[root-label]: Change to "Guix_image". * gnu/tests/install.scm (run-install): Remove "GuixSD". * guix/modules.scm (guix-module-name?): Likewise. * nix/libstore/optimise-store.cc: Likewise. --- gnu/system/examples/vm-image.tmpl | 2 +- gnu/system/install.scm | 2 +- gnu/system/mapped-devices.scm | 4 ++-- gnu/system/vm.scm | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) (limited to 'gnu/system') diff --git a/gnu/system/examples/vm-image.tmpl b/gnu/system/examples/vm-image.tmpl index 4d292c1bc..6dc67b090 100644 --- a/gnu/system/examples/vm-image.tmpl +++ b/gnu/system/examples/vm-image.tmpl @@ -8,7 +8,7 @@ (define vm-image-motd (plain-file "motd" " This is the GNU system. Welcome! -This instance of GuixSD is a bare-bones template for virtualized environments. +This instance of Guix System is a bare-bones template for virtualized environments. You will probably want to do these things first if you booted in a virtual private server (VPS): diff --git a/gnu/system/install.scm b/gnu/system/install.scm index 0ba2066d1..bad318d06 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -353,7 +353,7 @@ You have been warned. Thanks for being so brave.\x1b[0m ;; the appropriate one. (cons* (file-system (mount-point "/") - (device (file-system-label "GuixSD_image")) + (device (file-system-label "Guix_image")) (type "ext4")) ;; Make /tmp a tmpfs instead of keeping the overlayfs. This diff --git a/gnu/system/mapped-devices.scm b/gnu/system/mapped-devices.scm index a87466646..e29ad3ad3 100644 --- a/gnu/system/mapped-devices.scm +++ b/gnu/system/mapped-devices.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2014, 2015, 2016, 2017, 2018 Ludovic Courtès +;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès ;;; Copyright © 2016 Andreas Enge ;;; Copyright © 2017, 2018 Mark H Weaver ;;; @@ -120,7 +120,7 @@ DEVICE must be a \"/dev\" file name." (define aliases ;; Attempt to load 'modules.alias' from the current kernel, assuming we're - ;; on GuixSD, and assuming that corresponds to the kernel we'll be + ;; on Guix System, and assuming that corresponds to the kernel we'll be ;; installing. Skip the whole thing if that file cannot be read. (catch 'system-error (lambda () diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index e09c687a0..e56128596 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -463,8 +463,8 @@ the image." "Build a docker image. OS is the desired . NAME is the base name to use for the output file. When REGISTER-CLOSURES? is not #f, register the closure of OS with Guix in the resulting Docker image. This only -makes sense when you want to build a GuixSD Docker image that has Guix -installed inside of it. If you don't need Guix (e.g., your GuixSD Docker +makes sense when you want to build a Guix System Docker image that has Guix +installed inside of it. If you don't need Guix (e.g., your Docker image just contains a web server that is started by the Shepherd), then you should set REGISTER-CLOSURES? to #f." (define schema @@ -610,7 +610,7 @@ to USB sticks meant to be read-only." (define root-label ;; Volume name of the root file system. - (normalize-label "GuixSD_image")) + (normalize-label "Guix_image")) (define root-uuid ;; UUID of the root file system, computed in a deterministic fashion. -- cgit v1.3 From 4cd386afae444f3ee603cd07d282b2eee3253555 Mon Sep 17 00:00:00 2001 From: Ludovic Courtès Date: Wed, 13 Mar 2019 17:11:19 +0100 Subject: linux-modules: Factorize 'missing-modules'. * gnu/build/linux-modules.scm (missing-modules): New procedure. * gnu/system/mapped-devices.scm (check-device-initrd-modules): Use it. --- gnu/build/linux-modules.scm | 27 +++++++++++++++++++-- gnu/system/mapped-devices.scm | 55 +++++++++++++++++-------------------------- 2 files changed, 47 insertions(+), 35 deletions(-) (limited to 'gnu/system') diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm index d99d1f01a..c66ef9701 100644 --- a/gnu/build/linux-modules.scm +++ b/gnu/build/linux-modules.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2014, 2016, 2018 Ludovic Courtès +;;; Copyright © 2014, 2016, 2018, 2019 Ludovic Courtès ;;; Copyright © 2017 Mathieu Othacehe ;;; ;;; This file is part of GNU Guix. @@ -47,7 +47,8 @@ device-module-aliases known-module-aliases - matching-modules)) + matching-modules + missing-modules)) ;;; Commentary: ;;; @@ -463,4 +464,26 @@ ALIAS is a string like \"scsi:t-0x00\" as returned by module))) known-aliases)) +(define* (missing-modules device modules-provided) + "Assuming MODULES-PROVIDED lists kernel modules that are already +provided--e.g., in the initrd, return the list of missing kernel modules that +are required to access DEVICE." + (define aliases + ;; Attempt to load 'modules.alias' from the current kernel, assuming we're + ;; on Guix System, and assuming that corresponds to the kernel we'll be + ;; installing. + (known-module-aliases)) + + (if aliases + (let* ((modules (delete-duplicates + (append-map (cut matching-modules <> aliases) + (device-module-aliases device)))) + + ;; Module names (not file names) are supposed to use underscores + ;; instead of hyphens. MODULES is a list of module names, whereas + ;; LINUX-MODULES is file names without '.ko', so normalize them. + (provided (map file-name->module-name modules-provided))) + (remove (cut member <> provided) modules)) + '())) + ;;; linux-modules.scm ends here diff --git a/gnu/system/mapped-devices.scm b/gnu/system/mapped-devices.scm index e29ad3ad3..7c58f876a 100644 --- a/gnu/system/mapped-devices.scm +++ b/gnu/system/mapped-devices.scm @@ -32,8 +32,7 @@ #:use-module (gnu system uuid) #:autoload (gnu build file-systems) (find-partition-by-luks-uuid) #:autoload (gnu build linux-modules) - (device-module-aliases matching-modules known-module-aliases - normalize-module-name file-name->module-name) + (missing-modules) #:autoload (gnu packages cryptsetup) (cryptsetup-static) #:autoload (gnu packages linux) (mdadm-static) #:use-module (srfi srfi-1) @@ -118,37 +117,27 @@ (define (check-device-initrd-modules device linux-modules location) "Raise an error if DEVICE needs modules beyond LINUX-MODULES to operate. DEVICE must be a \"/dev\" file name." - (define aliases - ;; Attempt to load 'modules.alias' from the current kernel, assuming we're - ;; on Guix System, and assuming that corresponds to the kernel we'll be - ;; installing. Skip the whole thing if that file cannot be read. + (define missing + ;; Attempt to determine missing modules. (catch 'system-error (lambda () - (known-module-aliases)) - (const #f))) - - (when aliases - (let* ((modules (delete-duplicates - (append-map (cut matching-modules <> aliases) - (device-module-aliases device)))) - - ;; Module names (not file names) are supposed to use underscores - ;; instead of hyphens. MODULES is a list of module names, whereas - ;; LINUX-MODULES is file names without '.ko', so normalize them. - (provided (map file-name->module-name linux-modules)) - (missing (remove (cut member <> provided) modules))) - (unless (null? missing) - ;; Note: What we suggest here is a list of module names (e.g., - ;; "usb_storage"), not file names (e.g., "usb-storage.ko"). This is - ;; OK because we have machinery that accepts both the hyphen and the - ;; underscore version. - (raise (condition - (&message - (message (format #f (G_ "you may need these modules \ + (missing-modules device linux-modules)) + + ;; If we can't do that (e.g., EPERM), skip the whole thing. + (const '()))) + + (unless (null? missing) + ;; Note: What we suggest here is a list of module names (e.g., + ;; "usb_storage"), not file names (e.g., "usb-storage.ko"). This is + ;; OK because we have machinery that accepts both the hyphen and the + ;; underscore version. + (raise (condition + (&message + (message (format #f (G_ "you may need these modules \ in the initrd for ~a:~{ ~a~}") - device missing))) - (&fix-hint - (hint (format #f (G_ "Try adding them to the + device missing))) + (&fix-hint + (hint (format #f (G_ "Try adding them to the @code{initrd-modules} field of your @code{operating-system} declaration, along these lines: @@ -161,9 +150,9 @@ these lines: If you think this diagnostic is inaccurate, use the @option{--skip-checks} option of @command{guix system}.\n") - missing))) - (&error-location - (location (source-properties->location location))))))))) + missing))) + (&error-location + (location (source-properties->location location))))))) ;;; -- cgit v1.3 From b94c80ff5d844f7763738ab5359fee72f11f9367 Mon Sep 17 00:00:00 2001 From: Ludovic Courtès Date: Wed, 13 Mar 2019 23:10:19 +0100 Subject: linux-container: 'containerized-operating-system' removes "useless" services. Fixes . Reported by Efraim Flashner . * gnu/system/linux-container.scm (containerized-operating-system) [useless-services]: New variable. Add 'services' field. --- gnu/system/linux-container.scm | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) (limited to 'gnu/system') diff --git a/gnu/system/linux-container.scm b/gnu/system/linux-container.scm index bceea4133..3fe3482d7 100644 --- a/gnu/system/linux-container.scm +++ b/gnu/system/linux-container.scm @@ -1,6 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2015 David Thompson -;;; Copyright © 2016, 2017 Ludovic Courtès +;;; Copyright © 2016, 2017, 2019 Ludovic Courtès ;;; ;;; This file is part of GNU Guix. ;;; @@ -28,6 +28,7 @@ #:use-module (guix modules) #:use-module (gnu build linux-container) #:use-module (gnu services) + #:use-module (gnu services base) #:use-module (gnu system) #:use-module (gnu system file-systems) #:export (system-container @@ -54,8 +55,19 @@ containerized OS." (file-system (inherit (file-system-mapping->bind-mount fs)) (needed-for-boot? #t))) + (define useless-services + ;; Services that make no sense in a container. Those that attempt to + ;; access /dev/tty[0-9] in particular cannot work in a container. + (list console-font-service-type + mingetty-service-type + agetty-service-type)) + (operating-system (inherit os) (swap-devices '()) ; disable swap + (services (remove (lambda (service) + (memq (service-kind service) + useless-services)) + (operating-system-user-services os))) (file-systems (append (map mapping->fs (cons %store-mapping mappings)) %container-file-systems user-file-systems)))) -- cgit v1.3